[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vect
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions |
|
Date: |
Tue, 10 May 2022 11:58:36 +0200 |
On Tue, May 3, 2022 at 9:30 AM ~eopxd <eopxd@git.sr.ht> wrote:
>
> From: eopXD <eop.chen@sifive.com>
>
> Signed-off-by: eop Chen <eop.chen@sifive.com>
> Reviewed-by: Frank Chang <frank.chang@sifive.com>
> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index f67ec1f249..a319cda969 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -4537,6 +4537,9 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1,
> \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> + uint32_t esz = sizeof(TD); \
> + uint32_t vlenb = simd_maxsz(desc); \
> + uint32_t vta = vext_vta(desc); \
> uint32_t i; \
> TD s1 = *((TD *)vs1 + HD(0)); \
> \
> @@ -4549,6 +4552,8 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1,
> \
> } \
> *((TD *)vd + HD(0)) = s1; \
> env->vstart = 0; \
> + /* set tail elements to 1s */ \
> + vext_set_elems_1s(vd, vta, esz, vlenb); \
> }
>
> /* vd[0] = sum(vs1[0], vs2[*]) */
> @@ -4618,6 +4623,9 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1,
> \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> + uint32_t esz = sizeof(TD); \
> + uint32_t vlenb = simd_maxsz(desc); \
> + uint32_t vta = vext_vta(desc); \
> uint32_t i; \
> TD s1 = *((TD *)vs1 + HD(0)); \
> \
> @@ -4630,6 +4638,8 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1,
> \
> } \
> *((TD *)vd + HD(0)) = s1; \
> env->vstart = 0; \
> + /* set tail elements to 1s */ \
> + vext_set_elems_1s(vd, vta, esz, vlenb); \
> }
>
> /* Unordered sum */
> @@ -4654,6 +4664,9 @@ void HELPER(vfwredsum_vs_h)(void *vd, void *v0, void
> *vs1,
> {
> uint32_t vm = vext_vm(desc);
> uint32_t vl = env->vl;
> + uint32_t esz = sizeof(uint32_t);
> + uint32_t vlenb = simd_maxsz(desc);
> + uint32_t vta = vext_vta(desc);
> uint32_t i;
> uint32_t s1 = *((uint32_t *)vs1 + H4(0));
>
> @@ -4667,6 +4680,8 @@ void HELPER(vfwredsum_vs_h)(void *vd, void *v0, void
> *vs1,
> }
> *((uint32_t *)vd + H4(0)) = s1;
> env->vstart = 0;
> + /* set tail elements to 1s */
> + vext_set_elems_1s(vd, vta, esz, vlenb);
> }
>
> void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void *vs1,
> @@ -4674,6 +4689,9 @@ void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void
> *vs1,
> {
> uint32_t vm = vext_vm(desc);
> uint32_t vl = env->vl;
> + uint32_t esz = sizeof(uint64_t);
> + uint32_t vlenb = simd_maxsz(desc);
> + uint32_t vta = vext_vta(desc);
> uint32_t i;
> uint64_t s1 = *((uint64_t *)vs1);
>
> @@ -4687,6 +4705,8 @@ void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void
> *vs1,
> }
> *((uint64_t *)vd) = s1;
> env->vstart = 0;
> + /* set tail elements to 1s */
> + vext_set_elems_1s(vd, vta, esz, vlenb);
> }
>
> /*
> --
> 2.34.2
>
>
- [PATCH qemu v14 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed, (continued)
- [PATCH qemu v14 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed, ~eopxd, 2022/05/03
- [PATCH qemu v14 08/15] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 05/15] target/riscv: rvv: Add tail agnostic for vector load / store instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 07/15] target/riscv: rvv: Add tail agnostic for vector integer shift instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 06/15] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions, ~eopxd, 2022/05/03
- Re: [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions,
Alistair Francis <=
- [PATCH qemu v14 10/15] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 09/15] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 13/15] target/riscv: rvv: Add tail agnostic for vector mask instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 14/15] target/riscv: rvv: Add tail agnostic for vector permutation instructions, ~eopxd, 2022/05/03
- [PATCH qemu v14 15/15] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior, ~eopxd, 2022/05/03