[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/11] target/s390x/helper: Clean ifdef'ry
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 07/11] target/s390x/helper: Clean ifdef'ry |
Date: |
Sat, 9 May 2020 15:09:06 +0200 |
All this code is guarded checking CONFIG_USER_ONLY definition.
Drop the duplicated checks.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
Suspicious ifdef'ry in s390_handle_wait() from commit 83f7f32901c.
---
target/s390x/helper.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 09f60406aa..26e3b366e8 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -33,6 +33,7 @@
#endif
#ifndef CONFIG_USER_ONLY
+
void s390x_tod_timer(void *opaque)
{
cpu_inject_clock_comparator((S390CPU *) opaque);
@@ -42,9 +43,6 @@ void s390x_cpu_timer(void *opaque)
{
cpu_inject_cpu_timer((S390CPU *) opaque);
}
-#endif
-
-#ifndef CONFIG_USER_ONLY
hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr)
{
@@ -98,14 +96,12 @@ void s390_handle_wait(S390CPU *cpu)
CPUState *cs = CPU(cpu);
if (s390_cpu_halt(cpu) == 0) {
-#ifndef CONFIG_USER_ONLY
if (is_special_wait_psw(cpu->env.psw.addr)) {
qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
} else {
cpu->env.crash_reason = S390_CRASH_REASON_DISABLED_WAIT;
qemu_system_guest_panicked(cpu_get_crash_info(cs));
}
-#endif
}
}
@@ -328,6 +324,7 @@ int s390_store_adtl_status(S390CPU *cpu, hwaddr addr,
hwaddr len)
cpu_physical_memory_unmap(sa, len, 1, len);
return 0;
}
+
#endif /* CONFIG_USER_ONLY */
void s390_cpu_dump_state(CPUState *cs, FILE *f, int flags)
--
2.21.3
- [PATCH 03/11] sysemu/tcg: Only declare tcg_allowed when TCG is available, (continued)
- [PATCH 03/11] sysemu/tcg: Only declare tcg_allowed when TCG is available, Philippe Mathieu-Daudé, 2020/05/09
- [PATCH 04/11] sysemu/hvf: Only declare hvf_allowed when HVF is available, Philippe Mathieu-Daudé, 2020/05/09
- [PATCH 05/11] target/ppc: Restrict PPCVirtualHypervisorClass to system-mode, Philippe Mathieu-Daudé, 2020/05/09
- [PATCH 06/11] target/s390x: Only compile decode_basedisp() on system-mode, Philippe Mathieu-Daudé, 2020/05/09
- [PATCH 07/11] target/s390x/helper: Clean ifdef'ry,
Philippe Mathieu-Daudé <=
- [PATCH 08/11] target/s390x: Restrict system-mode declarations, Philippe Mathieu-Daudé, 2020/05/09
[PATCH 09/11] target/cpu: Restrict handlers using hwaddr type to system-mode, Philippe Mathieu-Daudé, 2020/05/09