RE: [PATCH] riscv/spike: Change the default bios to use plain binary image

[Anup Patel]

> -----Original Message-----
> From: Qemu-riscv <qemu-riscv-
> bounces+anup.patel=address@hidden> On Behalf Of Bin Meng
> Sent: 01 May 2020 18:15
> To: Anup Patel <address@hidden>
> Cc: Bin Meng <address@hidden>; open list:RISC-V <qemu-
> address@hidden>; Sagar Karandikar <address@hidden>; Bastian
> Koppelmann <address@hidden>; Palmer Dabbelt
> <address@hidden>; QEMU Developers <qemu-
> address@hidden>; Alistair Francis <address@hidden>
> Subject: Re: [PATCH] riscv/spike: Change the default bios to use plain binary
> image
> 
> On Fri, May 1, 2020 at 8:41 PM Anup Patel <address@hidden> wrote:
> >
> > On Fri, May 1, 2020 at 6:01 PM Bin Meng <address@hidden> wrote:
> > >
> > > From: Bin Meng <address@hidden>
> > >
> > > To keep sync with other RISC-V machines, change the default bios to
> > > use .bin instead of the .elf images.
> > >
> > > Signed-off-by: Bin Meng <address@hidden>
> > > ---
> > >
> > >  hw/riscv/spike.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index
> > > d0c4843..611a741 100644
> > > --- a/hw/riscv/spike.c
> > > +++ b/hw/riscv/spike.c
> > > @@ -46,9 +46,9 @@
> > >  #include <libfdt.h>
> > >
> > >  #if defined(TARGET_RISCV32)
> > > -# define BIOS_FILENAME "opensbi-riscv32-spike-fw_jump.elf"
> > > +# define BIOS_FILENAME "opensbi-riscv32-spike-fw_jump.bin"
> > >  #else
> > > -# define BIOS_FILENAME "opensbi-riscv64-spike-fw_jump.elf"
> > > +# define BIOS_FILENAME "opensbi-riscv64-spike-fw_jump.bin"
> > >  #endif
> >
> > This change breaks the console on the spike machine because HTIF
> > emulation depends on ELF parsing.
> 
> I think we should add some comments here.

Sure, adding comments here about ELF requirement is certainly helpful.

> 
> >
> > Keeping here ELF files was intentional because BIN files dont work for
> > Spike the machine.
> >
> > Also, now that OpenSBI generic platform is available. We can use same
> > OpenSBI firmware binaries/elfs on virt, sifive_u, and spike machines
> > of QEMU. I think:
> > 1. The QEMU build/makefile scripts for OpenSBI should be updated to
> > only build OpenSBI generic platform firmwares 2. The default
> > BIOS_FILENAME in for virt, sifive_u, and spike machines should be
> > changed to use OpenSBI generic platform firmwares.
> >
> > It would be great if you can drop this patch and instead do above two
> > changes. Agree ??
> 
> Agree.

Coo, thanks.

Regards,
Anup