Re: [PATCH RESEND] tests/avocado: ppc: Add smoke tests for MPC7400 and MPC7450 families

[Cédric Le Goater]

On 1/17/22 21:08, Daniel Henrique Barboza wrote:
> On 1/17/22 11:47, Fabiano Rosas wrote:
> > These tests ensure that our emulation for these cpus is not completely
> > broken and we can at least run OpenBIOS on them.
> >
> > $ make check-avocado AVOCADO_TESTS=../tests/avocado/ppc_74xx.py
> >
> > Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> > ---
> > ---
> >   tests/avocado/ppc_74xx.py | 123 ++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 123 insertions(+)
> >   create mode 100644 tests/avocado/ppc_74xx.py
> >
> > diff --git a/tests/avocado/ppc_74xx.py b/tests/avocado/ppc_74xx.py
> > new file mode 100644
> > index 0000000000..556a9a7da9
> > --- /dev/null
> > +++ b/tests/avocado/ppc_74xx.py
> > @@ -0,0 +1,123 @@
> > +# Smoke tests for 74xx cpus (aka G4).
> > +#
> > +# Copyright (c) 2021, IBM Corp.
>
>
> Not sure if the copyright year must be changed to 2022 (the year that this is 
> going to
> be published) or 2021 (the year that it was developed). GNU docs isn't clear 
> about
> it. Our COPYING file is also not clear about whether we should put the code 
> creation
> or code publishing year in this header.
>
> I don't mind leaving it as 2021. I'm just curious about what is the semantics 
> involved
> here.

Here is a brief summary of the IBM rules :

   Copyright IBM Corp. Year 1, Year 2

Year 1 is the year of first external delivery.

Year 2 is the year of the first external distribution of the latest
substantial changes (Only added when changes have been made).

I think we are fine with the above Copyright statement.

Thanks,

C.
 
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
>
> > +#
> > +# This work is licensed under the terms of the GNU GPL, version 2 or
> > +# later.  See the COPYING file in the top-level directory.
> > +
> > +from avocado_qemu import QemuSystemTest
> > +from avocado_qemu import wait_for_console_pattern
> > +
> > +class ppc74xxCpu(QemuSystemTest):
> > +    """
> > +    :avocado: tags=arch:ppc
> > +    """
> > +    timeout = 5
> > +
> > +    def test_ppc_7400(self):
> > +        """
> > +        :avocado: tags=cpu:7400
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7410(self):
> > +        """
> > +        :avocado: tags=cpu:7410
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,74xx')
> > +
> > +    def test_ppc_7441(self):
> > +        """
> > +        :avocado: tags=cpu:7441
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7445(self):
> > +        """
> > +        :avocado: tags=cpu:7445
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7447(self):
> > +        """
> > +        :avocado: tags=cpu:7447
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7447a(self):
> > +        """
> > +        :avocado: tags=cpu:7447a
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7448(self):
> > +        """
> > +        :avocado: tags=cpu:7448
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,MPC86xx')
> > +
> > +    def test_ppc_7450(self):
> > +        """
> > +        :avocado: tags=cpu:7450
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7451(self):
> > +        """
> > +        :avocado: tags=cpu:7451
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7455(self):
> > +        """
> > +        :avocado: tags=cpu:7455
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7457(self):
> > +        """
> > +        :avocado: tags=cpu:7457
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> > +
> > +    def test_ppc_7457a(self):
> > +        """
> > +        :avocado: tags=cpu:7457a
> > +        """
> > +        self.vm.set_console()
> > +        self.vm.launch()
> > +        wait_for_console_pattern(self, '>> OpenBIOS')
> > +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')