Re: [PATCH RESEND] tests/avocado: ppc: Add smoke tests for MPC7400 and MPC7450 families

[Philippe Mathieu-Daudé]

Hi,

You forgot to Cc the maintainers [*]:

% ./scripts/get_maintainer.pl -f tests/avocado/ppc_74xx.py
Cleber Rosa <crosa@redhat.com> (reviewer:Integration Testi...)
"Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:Integration Testi...)
Wainer dos Santos Moschetta <wainersm@redhat.com> (reviewer:Integration 
Testi...)
Beraldo Leal <bleal@redhat.com> (reviewer:Integration Testi...)
qemu-devel@nongnu.org (open list:All patches CC here)

Doing it for you now. But since the patch is already reviewed,
it should normally be merged via the PPC tree (see commit 6634f1c43d0
for rationale).

[*] 
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer

Since you are contributing various patches, you can see in this link
a tip (via git-config) to automatically call get_maintainers script.

On 17/1/22 15:47, Fabiano Rosas wrote:
> These tests ensure that our emulation for these cpus is not completely
> broken and we can at least run OpenBIOS on them.
>
> $ make check-avocado AVOCADO_TESTS=../tests/avocado/ppc_74xx.py
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> ---
> ---
>   tests/avocado/ppc_74xx.py | 123 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 123 insertions(+)
>   create mode 100644 tests/avocado/ppc_74xx.py
>
> diff --git a/tests/avocado/ppc_74xx.py b/tests/avocado/ppc_74xx.py
> new file mode 100644
> index 0000000000..556a9a7da9
> --- /dev/null
> +++ b/tests/avocado/ppc_74xx.py
> @@ -0,0 +1,123 @@
> +# Smoke tests for 74xx cpus (aka G4).
> +#
> +# Copyright (c) 2021, IBM Corp.
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or
> +# later.  See the COPYING file in the top-level directory.
> +
> +from avocado_qemu import QemuSystemTest
> +from avocado_qemu import wait_for_console_pattern
> +
> +class ppc74xxCpu(QemuSystemTest):
> +    """
> +    :avocado: tags=arch:ppc
> +    """
> +    timeout = 5
> +
> +    def test_ppc_7400(self):
> +        """
> +        :avocado: tags=cpu:7400
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7410(self):
> +        """
> +        :avocado: tags=cpu:7410
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,74xx')
> +
> +    def test_ppc_7441(self):
> +        """
> +        :avocado: tags=cpu:7441
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7445(self):
> +        """
> +        :avocado: tags=cpu:7445
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7447(self):
> +        """
> +        :avocado: tags=cpu:7447
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7447a(self):
> +        """
> +        :avocado: tags=cpu:7447a
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7448(self):
> +        """
> +        :avocado: tags=cpu:7448
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,MPC86xx')
> +
> +    def test_ppc_7450(self):
> +        """
> +        :avocado: tags=cpu:7450
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7451(self):
> +        """
> +        :avocado: tags=cpu:7451
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7455(self):
> +        """
> +        :avocado: tags=cpu:7455
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7457(self):
> +        """
> +        :avocado: tags=cpu:7457
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')
> +
> +    def test_ppc_7457a(self):
> +        """
> +        :avocado: tags=cpu:7457a
> +        """
> +        self.vm.set_console()
> +        self.vm.launch()
> +        wait_for_console_pattern(self, '>> OpenBIOS')
> +        wait_for_console_pattern(self, '>> CPU type PowerPC,G4')