[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU
From: |
address@hidden |
Subject: |
Re: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU |
Date: |
Tue, 1 Jun 2021 12:47:37 +1000 |
On Mon, May 31, 2021 at 05:46:07PM +0000, Luis Fernando Fujita Pires wrote:
> From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > This feature will no longer be useful as ppc moves to using decotree for
> > TCG.
> > And building with it enabled is no longer possible, due to changes in
> > opc_handler_t. Since the last commit that mentions it happened in 2014, I
> > think
> > it is safe to remove it.
> >
> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > ---
> > target/ppc/cpu_init.c | 205 -----------------------------------------
> > target/ppc/internal.h | 2 -
> > target/ppc/translate.c | 105 ---------------------
> > 3 files changed, 312 deletions(-)
>
> I believe you lost Richard's review for this one. In addition to approving
> it, he also noted the a typo in the commit message ("decotree" ->
> "decodetree").
I folded in the typo fix and Richard's R-b for this patch and the
previous one.
> Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 2/4] HMP: added info cpustats to removed_features.rst, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 1/4] hw/core/cpu: removed cpu_dump_statistics function, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 3/4] target/ppc: removed GEN_OPCODE decision tree, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU, Bruno Larsen (billionai), 2021/05/31
- Re: [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU, David Gibson, 2021/05/31