[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU
|
From: |
Luis Fernando Fujita Pires |
|
Subject: |
RE: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU |
|
Date: |
Mon, 31 May 2021 17:46:07 +0000 |
From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> This feature will no longer be useful as ppc moves to using decotree for TCG.
> And building with it enabled is no longer possible, due to changes in
> opc_handler_t. Since the last commit that mentions it happened in 2014, I
> think
> it is safe to remove it.
>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> ---
> target/ppc/cpu_init.c | 205 -----------------------------------------
> target/ppc/internal.h | 2 -
> target/ppc/translate.c | 105 ---------------------
> 3 files changed, 312 deletions(-)
I believe you lost Richard's review for this one. In addition to approving it,
he also noted the a typo in the commit message ("decotree" -> "decodetree").
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
- [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 2/4] HMP: added info cpustats to removed_features.rst, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 1/4] hw/core/cpu: removed cpu_dump_statistics function, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 3/4] target/ppc: removed GEN_OPCODE decision tree, Bruno Larsen (billionai), 2021/05/31
- [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU, Bruno Larsen (billionai), 2021/05/31
- RE: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU,
Luis Fernando Fujita Pires <=
- Re: [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU, David Gibson, 2021/05/31