qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 3/5] target/ppc: removed mentions to DO_PPC_STATISTICS


From: Luis Fernando Fujita Pires
Subject: RE: [PATCH 3/5] target/ppc: removed mentions to DO_PPC_STATISTICS
Date: Wed, 26 May 2021 21:35:18 +0000

From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> Removed the commented out definition and all ifdefs relating to
> PPC_DUMP_STATISTICS, as it's hardly ever used.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> ---
>  target/ppc/translate.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

The change looks good. Just a minor note: part of the commit msg is wrong, 
where you mention "PPC_DUMP_STATISTICS". The #define is DO_PPC_STATISTICS, and 
the function was ppc_cpu_dump_statistics(). You're probably referring to the 
former.

Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>

--
Luis Pires
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br>
Departamento de Computação Embarcada
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]