|
| From: | Luis Fernando Fujita Pires |
| Subject: | RE: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics |
| Date: | Wed, 26 May 2021 21:27:51 +0000 |
|
From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > This function requires surce code modification to be useful, which means it > probably is not used often, and the move to using decodetree means the > statistics won't even be collected anymore. > > Also removed setting dump_statistics in ppc_cpu_realize, since it was only useful > when in conjunction with ppc_cpu_dump_statistics. > > Suggested-by: Richard Henderson<richard.henderson@linaro.org> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > --- > target/ppc/cpu.h | 1 - > target/ppc/cpu_init.c | 3 --- > target/ppc/translate.c | 51 ------------------------------------------ > 3 files changed, 55 deletions(-) It's not just that ppc_cpu_dump_statistics() wouldn't be useful, but it wouldn't even compile. The change looks good. Reviewed-by: Luis Pires <luis.pires@eldorado.org.br> Luis Pires Instituto de Pesquisas ELDORADO Departamento de Computação Embarcada |
| [Prev in Thread] | Current Thread | [Next in Thread] |