|
| From: | Matheus K. Ferst |
| Subject: | Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree |
| Date: | Fri, 21 May 2021 14:25:21 -0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 18/05/2021 07:12, Richard Henderson wrote:
On 5/17/21 3:50 PM, matheus.ferst@eldorado.org.br wrote:+ if(a->l && (ctx->insns_flags & PPC_64B)) {Space after IF. > If I look back to the 6xx manual, I see NOTE: If L = 1, the instruction form is invalid.The fact that we're allowing L=1 for ppc32 is an existing bug, afaics. We should fix that.r~
The previous commit on this line in translate.c says that "on most 32bit CPUs we should always treat the compare as 32bit compare, as the CPU will ignore the L bit", so maybe it was intentional. Should we change it anyway?
-- Matheus K. Ferst Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/> Analista de Software Júnior Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
| [Prev in Thread] | Current Thread | [Next in Thread] |