qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree


From: Richard Henderson
Subject: Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree
Date: Tue, 18 May 2021 05:12:15 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/17/21 3:50 PM, matheus.ferst@eldorado.org.br wrote:
+    if(a->l && (ctx->insns_flags & PPC_64B)) {

Space after IF.

If I look back to the 6xx manual, I see

  NOTE: If L = 1, the instruction form is invalid.

The fact that we're allowing L=1 for ppc32 is an existing bug, afaics. We should fix that.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]