qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/23] chardev/baum: Replace magic values by X_MAX / Y_MAX de


From: Marc-André Lureau
Subject: Re: [PATCH 02/23] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions
Date: Thu, 6 May 2021 01:24:48 +0400



On Thu, May 6, 2021 at 1:13 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 chardev/baum.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/chardev/baum.c b/chardev/baum.c
index 5deca778bc4..adc3d7b3b56 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -87,6 +87,9 @@

 #define BUF_SIZE 256

+#define X_MAX   84
+#define Y_MAX   1
+
 struct BaumChardev {
     Chardev parent;

@@ -244,11 +247,11 @@ static int baum_deferred_init(BaumChardev *baum)
         brlapi_perror("baum: brlapi__getDisplaySize");
         return 0;
     }
-    if (baum->y > 1) {
-        baum->y = 1;
+    if (baum->y > Y_MAX) {
+        baum->y = Y_MAX;
     }
-    if (baum->x > 84) {
-        baum->x = 84;
+    if (baum->x > X_MAX) {
+        baum->x = X_MAX;
     }

     con = qemu_console_lookup_by_index(0);
--
2.26.3




--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]