Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static

[Bruno Piazera Larsen]

On 03/05/2021 12:25, Richard Henderson wrote:

> On
>       5/3/21 4:28 AM, Bruno Piazera Larsen wrote:
>       
> > > Note for future cleanup: Make spr_tcg.c
> > >           be standalone as well. Just need to move a few declarations to
> > >           a translate.h.
> > >           
> > >         
> >         it's not that easy, unfortunately. The readers and writers use a
> >         lot of global variables declared in translate.c, so we'd need to
> >         create getters and setters, or some better solution, before
> >         doing that.
> >         
> >       
>       
>       No need for getters, and certainly not for setters (all of the
>       globals are write-once at startup).  Just move the declarations
>       into a shared translate.h.  That's what we've done for
>       target/arm/.
>       
>     
    Ah, I can take a look later, but this would be pretty low priority
    compared to what is being requested of us right now. And that's if
    we separate it like that anyway
>       
>       
>       r~
>       
>

--
Bruno Piazera Larsen

Instituto de Pesquisas ELDORADO

Departamento Computação Embarcada

Analista de Software Trainee

Aviso Legal - Disclaimer