Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic

[Bruno Piazera Larsen]

On 30/04/2021 01:25, Richard Henderson wrote:

> On
>       4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
>       
> > @@ -49,7 +54,12 @@ static inline void
> >         vscr_init(CPUPPCState *env, uint32_t val)
> >         
> >           {
> >         
> >               /* Altivec always uses round-to-nearest */
> >         
> >               set_float_rounding_mode(float_round_nearest_even,
> >         &env->vec_status);
> >         
> >         -    helper_mtvscr(env, val);
> >         
> >         +    /*
> >         
> >         +     * This comment is here just so the project will build.
> >         
> >         +     * The current solution is in another patch and will be
> >         
> >         +     * added when we figure out an internal fork of qemu
> >         
> >         +     */
> >         
> >         +    /* helper_mtvscr(env, val); */
> >         
> >           }
> >         
> >       
>       
>       (1) this is a separate change to splitting out cpu_init.c.
>       
>     
    Oh, yeah. I was going to remove this change for now, it was for
    building with disable-tcg, which is still not working
> (2) you
>       can't even do this without introducing a regression.
>       
>

The plan is to not just remove, but change with a common function. on a future series, though.

I'm just slightly concerned now that make check has not seen anything...

>       
>       
>       r~
>       
>

--
Bruno Piazera Larsen

Instituto de Pesquisas ELDORADO

Departamento Computação Embarcada

Analista de Software Trainee

Aviso Legal - Disclaimer