Re: [PATCH v2 4/7] target/ppc: turned SPR R/W callbacks not static

[Richard Henderson]

On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
> @@ -234,19 +235,19 @@ static void spr_read_tbu(DisasContext *ctx, int gprn, int 
> sprn)
>   }
>   
>   ATTRIBUTE_UNUSED
> -static void spr_read_atbl(DisasContext *ctx, int gprn, int sprn)
> +void spr_read_atbl(DisasContext *ctx, int gprn, int sprn)
>   {

You can drop the ATTRIBUTE_UNUSED at the same time.

It was only there to stop the static symbol from being signaled as unused; for 
a non-static symbol, the compiler obviously can't tell.

> diff --git a/target/ppc/spr_tcg.h b/target/ppc/spr_tcg.h
> new file mode 100644
> index 0000000000..b573a23e7b
> --- /dev/null
> +++ b/target/ppc/spr_tcg.h
> @@ -0,0 +1,121 @@
> +#ifndef SPR_TCG_H
> +#define SPR_TCG_H
> +
> +#include "qemu/osdep.h"
> +#include "cpu.h"
> +#include "exec/translator.h"
> +#include "tcg/tcg.h"

All new files get copyright headers.  No headers include osdep.h.  It doesn't 
appear that you need any headers for this file; just add

typedef struct DisasContext DisasContext;

to the top of the file.


r~