RE: [RFC PATCH 2/4] target/ppc: isolated SPR read/write callbacks

[Bruno Piazera Larsen]

> The 2 fscr functions below aren't readers and writers for the FSCR.
> Instead they're used by instructions related to facilities the FSCR
> can enable and disable - this generates the code to check the FSCR and
> generate an exception if the units are disabled.
>
> That doesn't mean they don't belong here, but it does mean

I think something got lost here... anyway, I just checked that these functions

and they're only used in spr_tcg.c.inc at this point, so I think I'll remove it

from the .h and make them static. And mention it in the commit message

as well

I could also put it in translate.c, but whoever needs to refactor this code next

would have as big a headache as we're having now.

Bruno Piazera Larsen

Instituto de Pesquisas ELDORADO

Departamento Computação Embarcada

Analista de Software Trainee

Aviso Legal - Disclaimer