Re: [PATCH 5/6] hw/isa/vt82c686: Simplify removing unuseful qemu_allocate_irqs() call

[Philippe Mathieu-Daudé]

On 3/24/21 12:43 AM, BALATON Zoltan wrote:
> On Wed, 24 Mar 2021, Philippe Mathieu-Daudé wrote:
>> Instead of creating an input IRQ with qemu_allocate_irqs()
>> to pass it as output IRQ of the PIC, with its handler simply
>> dispatching into the "intr" output IRQ, simplify by directly
>> connecting the PIC to the "intr" named output.
> 
> I think I've tried to do it that way first but it did not work for some
> reason, that's why I had to add the additional handler, but this was
> about a year ago so I don't remember the details. Did you test it still
> works or expect me to test it? (Note that testing with firmware only may
> not be enough as some firmwares don't use interrupts so only booting a
> guest might reveal a problem. Not sure about pegasos2 firmware but
> sam460ex U-Boot seems to poll instead of using IRQs.)

I tested with Fuloong2E (PMON + Linux).

>> Fixes: 3dc31cb8490 ("vt82c686: Move creation of ISA devices to the ISA
>> bridge")
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> hw/isa/vt82c686.c | 10 +---------
>> 1 file changed, 1 insertion(+), 9 deletions(-)