|
| From: | Bruno Piazera Larsen |
| Subject: | RE: [RFC PATCH 1/4] target/ppc: move opcode table logic to translate.c |
| Date: | Mon, 26 Apr 2021 19:29:54 +0000 |
|
> > code motion to remove opcode callback table from
> > translate_init.c.inc to translate.c in preparation > > to remove #include <translate_init.c.inc> from > > translate.c > > I'd mention the creation of destroy_ppc_opcodes since this patch is not > strictly just moving code.
Sure, will do for v2.
> > +#if defined(PPC_DUMP_CPU)
> > The commented out define for this was left behind.
Good catch! The define is going to still be used by a couple of things in cpu_init, though.
I'm guessing moving to internal.h is the best solution, but correct me if I'm wrong
Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee |
| [Prev in Thread] | Current Thread | [Next in Thread] |