[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions
From: |
Richard Henderson |
Subject: |
Re: [PATCH 6/6] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions |
Date: |
Thu, 18 Jun 2020 16:46:49 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/12/20 9:20 PM, Lijun Pan wrote:
> +#define VDIV_MOD_DO(name, op, element) \
> + void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \
> + { \
> + int i; \
> + \
> + for (i = 0; i < ARRAY_SIZE(r->element); i++) { \
> + r->element[i] = a->element[i] op b->element[i]; \
> + } \
> + }
You're missing all of the divide-by-zero handling.
r~
- Re: [PATCH 3/6] targetc/ppc: add vmulh{su}w instructions, (continued)
- [PATCH 5/6] fix the prototype of muls64/mulu64, Lijun Pan, 2020/06/13
- [PATCH 4/6] target/ppc: add vmulh{su}d instructions, Lijun Pan, 2020/06/13
- [PATCH 6/6] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions, Lijun Pan, 2020/06/13
- Re: [PATCH 6/6] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions,
Richard Henderson <=
- Re: [PATCH 0/6] Add several Power ISA 3.1 32/64-bit vector instructions, no-reply, 2020/06/13
- Re: [PATCH 0/6] Add several Power ISA 3.1 32/64-bit vector instructions, Cédric Le Goater, 2020/06/15
- Re: [PATCH 0/6] Add several Power ISA 3.1 32/64-bit vector instructions, Richard Henderson, 2020/06/18