Re: [PATCH 4/6] target/ppc: add vmulh{su}d instructions

[Richard Henderson]

On 6/12/20 9:20 PM, Lijun Pan wrote:
> +void helper_vmulhsd(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
> +{
> +     int i;
> +     uint64_t h64 = 0;
> +     uint64_t l64 = 0;
> +
> +     for (i = 0; i < 2; i++) {
> +             muls64(&l64, &h64, a->s64[i], b->s64[i]);
> +             r->s64[i] = h64;
> +     }
> +}

Indentation is off.

This can just as easily be written as

    uint64_t discard;

    muls64(&discard, &r->u64[0], a->s64[0], b->s64[0]);
    muls64(&discard, &r->u64[1], a->s64[1], b->s64[1]);

and similarly for helper_vmulhud.


r~