[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] ppc: sreset and machine check injection
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 0/5] ppc: sreset and machine check injection |
Date: |
Wed, 25 Mar 2020 17:42:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 3/25/20 3:41 PM, Nicholas Piggin wrote:
> This adds nmi injection for pnv, and similar mce injection for
> spapr and pnv. The mce injection has already uncovered quite a
> few bugs in Linux papr guest and one in pnv host code, so it
> has been already very useful.
Nice !
> The mambo simulator can do similar
> injection but it's a bit more clunky and needs to run KVM and
> QEMU in the sim to test papr guests, which is quite slow.
You can run a KVM guest under the QEMU powernv machine. You will
need a patch from Suraj adding radix support for guests, which is
still in my powernv-5.0 branch.
> HMIs like timebase corruption would be another good candidate
> for error injection.
XSCOM errors also.
Thanks,
C.
> Thanks,
> Nick
>
> Nicholas Piggin (5):
> ppc/spapr: tweak change system reset helper
> ppc/pnv: Add support for NMI interface
> nmi: add MCE class for implementing machine check injection commands
> ppc/spapr: Implement mce injection
> ppc/pnv: Implement mce injection
>
> hmp-commands.hx | 20 ++++++++-
> hw/core/nmi.c | 61 ++++++++++++++++++++++++++
> hw/ppc/pnv.c | 85 +++++++++++++++++++++++++++++++++++-
> hw/ppc/spapr.c | 63 ++++++++++++++++++++++++--
> include/hw/nmi.h | 20 +++++++++
> include/hw/ppc/spapr.h | 3 ++
> include/monitor/hmp-target.h | 1 -
> include/monitor/hmp.h | 1 +
> monitor/hmp-cmds.c | 1 +
> target/ppc/cpu.h | 3 +-
> target/ppc/excp_helper.c | 17 ++++++--
> target/ppc/monitor.c | 11 +++++
> 12 files changed, 275 insertions(+), 11 deletions(-)
>
- Re: [PATCH 2/5] ppc/pnv: Add support for NMI interface, (continued)