[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 10/15] ppc/pnv: extend XSCOM core support for P
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 10/15] ppc/pnv: extend XSCOM core support for POWER9 |
Date: |
Fri, 8 Mar 2019 11:31:16 +1100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Thu, Mar 07, 2019 at 11:35:43PM +0100, Cédric Le Goater wrote:
> Provide a new class attribute to define XSCOM operations per CPU
> family and add a couple of XSCOM addresses controlling the power
> management states of the core on POWER9.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Applied, thanks.
> ---
>
> Changes in v2 :
>
> - new class attribute to define XSCOM operations per CPU family
>
> include/hw/ppc/pnv_core.h | 2 +
> hw/ppc/pnv_core.c | 100 +++++++++++++++++++++++++++++++++-----
> 2 files changed, 89 insertions(+), 13 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> index 6874bb847a01..cbe9ad36f32c 100644
> --- a/include/hw/ppc/pnv_core.h
> +++ b/include/hw/ppc/pnv_core.h
> @@ -42,6 +42,8 @@ typedef struct PnvCore {
>
> typedef struct PnvCoreClass {
> DeviceClass parent_class;
> +
> + const MemoryRegionOps *xscom_ops;
> } PnvCoreClass;
>
> #define PNV_CORE_TYPE_SUFFIX "-" TYPE_PNV_CORE
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index 38179cdc53dc..171474e0805c 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -60,8 +60,8 @@ static void pnv_cpu_reset(void *opaque)
> #define PNV_XSCOM_EX_DTS_RESULT0 0x50000
> #define PNV_XSCOM_EX_DTS_RESULT1 0x50001
>
> -static uint64_t pnv_core_xscom_read(void *opaque, hwaddr addr,
> - unsigned int width)
> +static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> + unsigned int width)
> {
> uint32_t offset = addr >> 3;
> uint64_t val = 0;
> @@ -82,16 +82,74 @@ static uint64_t pnv_core_xscom_read(void *opaque, hwaddr
> addr,
> return val;
> }
>
> -static void pnv_core_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> - unsigned int width)
> +static void pnv_core_power8_xscom_write(void *opaque, hwaddr addr, uint64_t
> val,
> + unsigned int width)
> {
> qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> addr);
> }
>
> -static const MemoryRegionOps pnv_core_xscom_ops = {
> - .read = pnv_core_xscom_read,
> - .write = pnv_core_xscom_write,
> +static const MemoryRegionOps pnv_core_power8_xscom_ops = {
> + .read = pnv_core_power8_xscom_read,
> + .write = pnv_core_power8_xscom_write,
> + .valid.min_access_size = 8,
> + .valid.max_access_size = 8,
> + .impl.min_access_size = 8,
> + .impl.max_access_size = 8,
> + .endianness = DEVICE_BIG_ENDIAN,
> +};
> +
> +
> +/*
> + * POWER9 core controls
> + */
> +#define PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_HYP 0xf010d
> +#define PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR 0xf010a
> +
> +static uint64_t pnv_core_power9_xscom_read(void *opaque, hwaddr addr,
> + unsigned int width)
> +{
> + uint32_t offset = addr >> 3;
> + uint64_t val = 0;
> +
> + /* The result should be 38 C */
> + switch (offset) {
> + case PNV_XSCOM_EX_DTS_RESULT0:
> + val = 0x26f024f023f0000ull;
> + break;
> + case PNV_XSCOM_EX_DTS_RESULT1:
> + val = 0x24f000000000000ull;
> + break;
> + case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_HYP:
> + case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
> + val = 0x0;
> + break;
> + default:
> + qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> + addr);
> + }
> +
> + return val;
> +}
> +
> +static void pnv_core_power9_xscom_write(void *opaque, hwaddr addr, uint64_t
> val,
> + unsigned int width)
> +{
> + uint32_t offset = addr >> 3;
> +
> + switch (offset) {
> + case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_HYP:
> + case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
> + break;
> + default:
> + qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx
> "\n",
> + addr);
> + }
> +}
> +
> +static const MemoryRegionOps pnv_core_power9_xscom_ops = {
> + .read = pnv_core_power9_xscom_read,
> + .write = pnv_core_power9_xscom_write,
> .valid.min_access_size = 8,
> .valid.max_access_size = 8,
> .impl.min_access_size = 8,
> @@ -138,6 +196,7 @@ static void pnv_realize_vcpu(PowerPCCPU *cpu, PnvChip
> *chip, Error **errp)
> static void pnv_core_realize(DeviceState *dev, Error **errp)
> {
> PnvCore *pc = PNV_CORE(OBJECT(dev));
> + PnvCoreClass *pcc = PNV_CORE_GET_CLASS(pc);
> CPUCore *cc = CPU_CORE(OBJECT(dev));
> const char *typename = pnv_core_cpu_typename(pc);
> Error *local_err = NULL;
> @@ -180,7 +239,7 @@ static void pnv_core_realize(DeviceState *dev, Error
> **errp)
> }
>
> snprintf(name, sizeof(name), "xscom-core.%d", cc->core_id);
> - pnv_xscom_region_init(&pc->xscom_regs, OBJECT(dev), &pnv_core_xscom_ops,
> + pnv_xscom_region_init(&pc->xscom_regs, OBJECT(dev), pcc->xscom_ops,
> pc, name, PNV_XSCOM_EX_SIZE);
> return;
>
> @@ -222,6 +281,20 @@ static Property pnv_core_properties[] = {
> DEFINE_PROP_END_OF_LIST(),
> };
>
> +static void pnv_core_power8_class_init(ObjectClass *oc, void *data)
> +{
> + PnvCoreClass *pcc = PNV_CORE_CLASS(oc);
> +
> + pcc->xscom_ops = &pnv_core_power8_xscom_ops;
> +}
> +
> +static void pnv_core_power9_class_init(ObjectClass *oc, void *data)
> +{
> + PnvCoreClass *pcc = PNV_CORE_CLASS(oc);
> +
> + pcc->xscom_ops = &pnv_core_power9_xscom_ops;
> +}
> +
> static void pnv_core_class_init(ObjectClass *oc, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(oc);
> @@ -231,10 +304,11 @@ static void pnv_core_class_init(ObjectClass *oc, void
> *data)
> dc->props = pnv_core_properties;
> }
>
> -#define DEFINE_PNV_CORE_TYPE(cpu_model) \
> +#define DEFINE_PNV_CORE_TYPE(family, cpu_model) \
> { \
> .parent = TYPE_PNV_CORE, \
> .name = PNV_CORE_TYPE_NAME(cpu_model), \
> + .class_init = pnv_core_##family##_class_init, \
> }
>
> static const TypeInfo pnv_core_infos[] = {
> @@ -246,10 +320,10 @@ static const TypeInfo pnv_core_infos[] = {
> .class_init = pnv_core_class_init,
> .abstract = true,
> },
> - DEFINE_PNV_CORE_TYPE("power8e_v2.1"),
> - DEFINE_PNV_CORE_TYPE("power8_v2.0"),
> - DEFINE_PNV_CORE_TYPE("power8nvl_v1.0"),
> - DEFINE_PNV_CORE_TYPE("power9_v2.0"),
> + DEFINE_PNV_CORE_TYPE(power8, "power8e_v2.1"),
> + DEFINE_PNV_CORE_TYPE(power8, "power8_v2.0"),
> + DEFINE_PNV_CORE_TYPE(power8, "power8nvl_v1.0"),
> + DEFINE_PNV_CORE_TYPE(power9, "power9_v2.0"),
> };
>
> DEFINE_TYPES(pnv_core_infos)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCH v2 03/15] ppc/pnv: lpc: fix OPB address ranges, (continued)
- [Qemu-ppc] [PATCH v2 09/15] ppc/pnv: add a OCC model for POWER9, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 13/15] ppc/pnv: add more dummy XSCOM addresses, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 12/15] ppc/pnv: activate XSCOM tests for POWER9, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 02/15] ppc/pnv: add a PSI bridge model for POWER9, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 10/15] ppc/pnv: extend XSCOM core support for POWER9, Cédric Le Goater, 2019/03/07
- Re: [Qemu-ppc] [PATCH v2 10/15] ppc/pnv: extend XSCOM core support for POWER9,
David Gibson <=
- [Qemu-ppc] [PATCH v2 14/15] ppc/pnv: add a "ibm, opal/power-mgt" device tree node on POWER9, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 11/15] ppc/pnv: POWER9 XSCOM quad support, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 05/15] ppc/pnv: add a 'dt_isa_nodename' to the chip, Cédric Le Goater, 2019/03/07
- [Qemu-ppc] [PATCH v2 07/15] ppc/pnv: add SerIRQ routing registers, Cédric Le Goater, 2019/03/07