[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message |
Date: |
Tue, 23 Oct 2018 16:20:37 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Oct 18, 2018 at 05:03:55PM -0300, Eduardo Habkost wrote:
> From: David Hildenbrand <address@hidden>
>
> We're missing "x" after the leading 0.
>
> Reviewed-by: David Gibson <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/mem/memory-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 6de4f70bb4..0b52fe2c5e 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -120,7 +120,7 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
> const uint64_t *hint,
>
> /* address_space_start indicates the maximum alignment we expect */
> if (QEMU_ALIGN_UP(address_space_start, align) != address_space_start) {
> - error_setg(errp, "the alignment (0%" PRIx64 ") is not supported",
> + error_setg(errp, "the alignment (0x%" PRIx64 ") is not supported",
> align);
> return 0;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PULL 13/45] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device', (continued)
- [Qemu-ppc] [PULL 13/45] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device', Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 16/45] hw/mips/malta: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 17/45] machine: fix a typo, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message, Eduardo Habkost, 2018/10/18
- Re: [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message,
David Gibson <=
- [Qemu-ppc] [PULL 19/45] memory-device: fix error message when hinted address is too small, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 20/45] memory-device: improve "range conflicts" error message, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 21/45] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 22/45] memory-device: use memory device terminology in error messages, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 23/45] memory-device: introduce separate config option, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 24/45] memory-device: forward errors in get_region_size()/get_plugged_size(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 25/45] memory-device: document MemoryDeviceClass, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 26/45] memory-device: add and use memory_device_get_region_size(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 27/45] memory-device: factor out get_memory_region() from pc-dimm, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 29/45] memory-device: add device class function set_addr(), Eduardo Habkost, 2018/10/18