[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 20/45] memory-device: improve "range conflicts" error m
From: |
Eduardo Habkost |
Subject: |
[Qemu-ppc] [PULL 20/45] memory-device: improve "range conflicts" error message |
Date: |
Thu, 18 Oct 2018 17:03:57 -0300 |
From: David Hildenbrand <address@hidden>
Handle id==NULL better and indicate that we are dealing with memory
devices.
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 7c706fadfc..0624184c40 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -175,7 +175,8 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
const uint64_t *hint,
if (ranges_overlap(md_addr, md_size, new_addr, size)) {
if (hint) {
const DeviceState *d = DEVICE(md);
- error_setg(errp, "address range conflicts with '%s'", d->id);
+ error_setg(errp, "address range conflicts with memory device"
+ " id='%s'", d->id ? d->id : "(unnamed)");
goto out;
}
new_addr = QEMU_ALIGN_UP(md_addr + md_size, align);
--
2.18.0.rc1.1.g3f1ff2140
- Re: [Qemu-ppc] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code, (continued)
- [Qemu-ppc] [PULL 15/45] hw/hppa/dino: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 16/45] hw/mips/malta: Remove unuseful code, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 17/45] machine: fix a typo, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 18/45] memory-device: fix alignment error message, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 19/45] memory-device: fix error message when hinted address is too small, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 20/45] memory-device: improve "range conflicts" error message,
Eduardo Habkost <=
- [Qemu-ppc] [PULL 21/45] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 22/45] memory-device: use memory device terminology in error messages, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 23/45] memory-device: introduce separate config option, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 24/45] memory-device: forward errors in get_region_size()/get_plugged_size(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 25/45] memory-device: document MemoryDeviceClass, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 26/45] memory-device: add and use memory_device_get_region_size(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 27/45] memory-device: factor out get_memory_region() from pc-dimm, Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 29/45] memory-device: add device class function set_addr(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 28/45] memory-device: drop get_region_size(), Eduardo Habkost, 2018/10/18
- [Qemu-ppc] [PULL 31/45] memory-device: complete factoring out plug handling, Eduardo Habkost, 2018/10/18