[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 11/13] nvdimm: allow setting the label-size to
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-ppc] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0 |
|
Date: |
Mon, 18 Jun 2018 14:04:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 18.06.2018 14:03, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 16:04:46 +0200
> David Hildenbrand <address@hidden> wrote:
>
>> It is inititally 0, so setting it to 0 should be allowed, too.
> I'm not sure if we need to permit it.
> By default labels are disabled (label-size=0) and user are supposed to provide
> this option if labels should be enabled with a valid size.
>
> it could be confusing for user when asking for label and not getting it.
>
> I suggest to drop this patch, it's not really related to this series
> nor required for your future work.
>
As I just want to finally get this stuff off my table, I agree to
whatever you say.
--
Thanks,
David / dhildenb
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region(), (continued)
- [Qemu-ppc] [PATCH v3 07/13] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 12/13] nvdimm: make get_memory_region() perform checks and initialization, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 09/13] nvdimm: convert "unarmed" into a static property, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 13/13] pc-dimm: get_memory_region() will not fail after realize, David Hildenbrand, 2018/06/15
- Re: [Qemu-ppc] [PATCH v3 00/13] pc-dimm: next bunch of cleanups, David Hildenbrand, 2018/06/18