[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] prep: fix keyboard for the 40p machi
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] prep: fix keyboard for the 40p machine |
|
Date: |
Thu, 24 May 2018 20:07:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 24.05.2018 18:20, Philippe Mathieu-Daudé wrote:
> On 05/24/2018 02:39 AM, Mark Cave-Ayland wrote:
>> Commit 72d3d8f052 "hw/isa/superio: Add a keyboard/mouse controller (8042)"
>> added an 8042 keyboard device to the PC87312 superio device to replace that
>> being used by the prep machine.
>>
>> Unfortunately this commit didn't do the same for the 40p machine which broke
>> the keyboard by registering two 8042 keyboard devices at the same address.
[...]
> Thanks for fixing this (too bad there are no keyboard qtests and this
> got unnoticed).
Then it's time to write some tests? ;-)
Thomas
signature.asc
Description: OpenPGP digital signature