Re: [Qemu-ppc] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure

[Benjamin Herrenschmidt]

On Wed, 2016-09-07 at 17:55 +0200, Cédric Le Goater wrote:
> 
> yes. To hack my way through again, I have added a memory region under
> the XScomDevice, but we should have a list like the ranges[] because of 
> the PHB3 PCBQs.

You have the parent region in the chip. Then each device can create and attach
memory regions below if it feels like it. No need to have a generic XScomDevice
with a fixed list of regions I think. I mean, you can ... but you don't have to.

> > For device-tree, well, we could have a generic interface that anything
> > that can populate DT has and iterate through them. Or make a "chiplet"
> > class or something.
> 
> yes, something like the XScomDeviceClass, which serves well the purpose
> anyhow.