qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v2 1/7] ppc/pnv: add skeleton PowerNV platform


From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [PATCH v2 1/7] ppc/pnv: add skeleton PowerNV platform
Date: Mon, 5 Sep 2016 08:06:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

>> +static void ppc_powernv_reset(void)
>> +{
>> +    MachineState *machine = MACHINE(qdev_get_machine());
>> +    PnvMachineState *pnv = POWERNV_MACHINE(machine);
>> +    void *fdt;
>> +
>> +    pnv->fdt_addr = FDT_ADDR;
> 
> Not sure there's any point to pnv->fdt_addr, since it will always have
> the value FDT_ADDR.  Only worth changing if you're doing a respin for
> other reasons though.

Yes, you are probably right. I will take a look.

I have a new version with some basic core and xscom support for P9,
booting up to the interrupt setting in skiboot. So I was already 
planning for v3.

Thanks,

C.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]