[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v1 09/11] ppc/xics: Split ICS into ics-base and ic
From: |
Nikunj A Dadhania |
Subject: |
Re: [Qemu-ppc] [PATCH v1 09/11] ppc/xics: Split ICS into ics-base and ics class |
Date: |
Mon, 27 Jun 2016 10:48:24 +0530 |
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
David Gibson <address@hidden> writes:
> [ Unknown signature status ]
> On Thu, Jun 23, 2016 at 11:17:28PM +0530, Nikunj A Dadhania wrote:
>> From: Benjamin Herrenschmidt <address@hidden>
>>
>> The existing implementation remains same and ics-base is introduced.
>>
>> This will allow different implementations for the source controllers
>> such as the MSI support of PHB3 on Power8 which uses in-memory state
>> tables for example.
>>
>> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
>> Signed-off-by: Nikunj A Dadhania <address@hidden>
>> ---
>> hw/intc/xics.c | 101
>> +++++++++++++++++++++++++++++++++-----------------
>> hw/intc/xics_spapr.c | 36 ++++++++++--------
>> include/hw/ppc/xics.h | 11 +++++-
>> 3 files changed, 97 insertions(+), 51 deletions(-)
>>
>> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
>> index 326d21f..e2aa48d 100644
>> --- a/hw/intc/xics.c
>> +++ b/hw/intc/xics.c
>> @@ -220,9 +220,32 @@ static const TypeInfo xics_common_info = {
>> #define XISR(ss) (((ss)->xirr) & XISR_MASK)
>> #define CPPR(ss) (((ss)->xirr) >> 24)
>>
>> -static void ics_reject(ICSState *ics, int nr);
>> -static void ics_resend(ICSState *ics);
>> -static void ics_eoi(ICSState *ics, int nr);
>> +static void ics_base_reject(ICSState *ics, uint32_t nr)
>
> AFICT these will actually work for any of the derived classes, since
> they call the function pointer. So I thin the original name was
> better than ics_base_*().
Sure, will change.
Regards
Nikunj