Re: [Qemu-ppc] [RFC PATCH] pseries: use qemu_irq_raise() in spapr_msi_write()

[David Gibson]

On Tue, May 10, 2016 at 09:18:13AM +0800, Li Zhong wrote:
> It seems that both ics_set_irq() and ics_kvm_set_irq() don't do anything
> useful for MSIs with val = 0, so maybe the pulse in spapr_msi_write()
> could be replaced with a single raise?
> 
> Signed-off-by: Li Zhong <address@hidden>

I'm not clear.  Does the current code actually cause problems?  Or are
you just suggesting a cleanup?

I believe the convention in qemu is that edge or message triggered
interrupts are tripped with qemu_irq_pulse().

> ---
>  hw/ppc/spapr_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 573e635..897c541 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -732,7 +732,7 @@ static void spapr_msi_write(void *opaque, hwaddr addr,
>  
>      trace_spapr_pci_msi_write(addr, data, irq);
>  
> -    qemu_irq_pulse(xics_get_qirq(spapr->icp, irq));
> +    qemu_irq_raise(xics_get_qirq(spapr->icp, irq));
>  }
>  
>  static const MemoryRegionOps spapr_msi_ops = {

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature