[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 01/16] Bad zero comparison for sas_ss_flags on powerpc
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 01/16] Bad zero comparison for sas_ss_flags on powerpc |
Date: |
Thu, 15 Mar 2012 13:14:07 +0100 |
From: Alex Barcelo <address@hidden>
All architectures work the same way, and all check for sas_ss_flags ==
0. The powerpc lines are wrong, and do the check the other way round
(it's a qemu internal check, which is done wrong only for this
architecture, it's more a typo than a bug). It's NOT ppc specific,
it's POSIX standard (sigaltstack) and qemu internal.
I have a test source that I will send in a follow-up (it's longer than
I would have wished, I'm sure that a better test case can be written
if needed)
Signed-off-by: Alex Barcelo <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
linux-user/signal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index fca51e2..b1e139d 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -4118,7 +4118,7 @@ static target_ulong get_sigframe(struct target_sigaction
*ka,
oldsp = env->gpr[1];
if ((ka->sa_flags & TARGET_SA_ONSTACK) &&
- (sas_ss_flags(oldsp))) {
+ (sas_ss_flags(oldsp) == 0)) {
oldsp = (target_sigaltstack_used.ss_sp
+ target_sigaltstack_used.ss_size);
}
--
1.6.0.2
- [Qemu-ppc] [PULL 00/16] ppc patch queue 2012-03-15, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 01/16] Bad zero comparison for sas_ss_flags on powerpc,
Alexander Graf <=
- [Qemu-ppc] [PATCH 03/16] ppc: Add missing 'static' to spin_rw_ops, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 02/16] PPC: 405: Fix ppc405ep initialization, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 13/16] kvm: Comparison with ioctl number macros needs to be unsigned, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 15/16] pseries: Configure PCI bridge using properties, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 08/16] pseries: Remove PCI device from PCI host bridge code, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 16/16] PPC: Fix openpic with relative memregions, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 09/16] PPC: Add PIR register to POWER7 CPU, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 12/16] ppc: Correctly define POWERPC_INSNS2_DEFAULT, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 11/16] pseries: Add support for level interrupts to XICS, Alexander Graf, 2012/03/15
- [Qemu-ppc] [PATCH 04/16] pseries: Don't try to munmap() a malloc()ed TCE table, Alexander Graf, 2012/03/15