Why qemu migration destination don't set setup state

[马昊骢 Ianmalcolm Ma]

Hello

 

When I read migration source code, I find when migrationIn init, it send event to libvirt by function“qemu_start_incoming_migration”with content “"event": "MIGRATION", "data": {"status": "setup"}}”.

But  I’m confused that why qemu don’t  set  self state like “migrate_set_state”.  Is this not necessary, or any other considerations ?

On the other hand, when I read the function of multifd,  when migrationIn initial multifd channel, if the process failed, it will close all channel by using “multifd_recv_terminate_threads”. 

But this error will only change from setup to failed or active to failed, so is it possible that failed state can not be set correctly when multifd init error ?

My qemu version is 2.10. I also clone master branch on github,  and it looks like there is no difference between this two version on function“multifd_recv_terminate_threads”and“qemu_start_incoming_migration”.

Thanks