Re: [Qemu-discuss] Apple hyphervisor.framework availability

[Paolo Bonzini]

On 25/11/2017 11:48, Brendan Simon (eTRIX) wrote:
> On 25/11/17 10:10 am, Brendan Simon (eTRIX) wrote:
> 
>> On 24/11/17 11:39 pm, Paolo Bonzini wrote:
>>> On 24/11/2017 12:58, Brendan Simon (eTRIX) wrote:
>>>> Checked out the `hvf` branch, but it failed the build.  Ran `mkdir build
>>>> ; cd build ; ../configure ; make`
>>>>
>>>> Am I missing some definitions or command line switches?
>>> No, I've pushed an updated version.
>>
>> Making progress but build fails as `target_ulong` is not defined.  I
>> had a quick hunt through the code and it looked like `cpu-defs.h`
>> should be included, but obviously something is not right (either not
>> being included, or the typedef is being excluded for some reason).
>>
>>   CC      x86_64-softmmu/target/i386/hvf/x86.o
>> In file included from
>> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86.c:22:
>> In file included from
>> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_decode.h:22:
>> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86.h:292:5:
>> error: unknown type name 'target_ulong'
>>     target_ulong result;
>>     ^
> 
> So I'm doing some hacking to see if can progress this further.  I added
> `#include "cpu.h"` in `target/i386/hvf/x86.c` and moved `#include
> "cpu.h"` up a little in `target/i386/hvf/x86_decode.h`.  That seemed to
> get me a little further.

Good, thanks.  I did a slightly different change that hopefully didn't
screw up something else.

> I then got compile errors re couldn't find `panic.h`.  So my quick and
> dirty hack was to replace `#include "panic.h"` with `#include
> "hvf-utils/panic.h"` in the files `target/i386/hvf/x86_decode.c` and
> `target/i386/hvf/x86_emu.c`.  That gets me a little further.

The intended fix here is to move the panic.h file from
target/i386/hvf-utils to target/i386/hvf.

> I now get the following and am stuck.  I've looked through the flags
> code but it's just too low level for me to workout any kind of workaround.

The two missing arguments here (second and third) can just be 0.

Thanks for helping out!  As you can see, this wasn't quite yet ready for
consumption...

Paolo