Re: [Qemu-discuss] Apple hyphervisor.framework availability

[Brendan Simon (eTRIX)]

On 25/11/17 10:10 am, Brendan Simon (eTRIX) wrote:

> On 24/11/17 11:39 pm, Paolo Bonzini wrote:
>> On 24/11/2017 12:58, Brendan Simon (eTRIX) wrote:
>>> Checked out the `hvf` branch, but it failed the build.  Ran `mkdir build
>>> ; cd build ; ../configure ; make`
>>>
>>> Am I missing some definitions or command line switches?
>> No, I've pushed an updated version.
>
> Making progress but build fails as `target_ulong` is not defined.  I
> had a quick hunt through the code and it looked like `cpu-defs.h`
> should be included, but obviously something is not right (either not
> being included, or the typedef is being excluded for some reason).
>
>   CC      x86_64-softmmu/target/i386/hvf/x86.o
> In file included from
> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86.c:22:
> In file included from
> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_decode.h:22:
> /Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86.h:292:5:
> error: unknown type name 'target_ulong'
>     target_ulong result;
>     ^

So I'm doing some hacking to see if can progress this further.  I added
`#include "cpu.h"` in `target/i386/hvf/x86.c` and moved `#include
"cpu.h"` up a little in `target/i386/hvf/x86_decode.h`.  That seemed to
get me a little further.

I then got compile errors re couldn't find `panic.h`.  So my quick and
dirty hack was to replace `#include "panic.h"` with `#include
"hvf-utils/panic.h"` in the files `target/i386/hvf/x86_decode.c` and
`target/i386/hvf/x86_emu.c`.  That gets me a little further.

I now get the following and am stuck.  I've looked through the flags
code but it's just too low level for me to workout any kind of workaround.

Any fixes/suggestions to resolve this?

  CC      x86_64-softmmu/target/i386/hvf/x86_emu.o
/Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_emu.c:957:41:
error: too few arguments to function call,
      expected 4, have 2
        SET_FLAGS_OSZAPC_LOGIC8(env, res);
        ~~~~~~~~~~~~~~~~~~~~~~~         ^
/Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_flags.h:77:1:
note: 'SET_FLAGS_OSZAPC_LOGIC8' declared here
void SET_FLAGS_OSZAPC_LOGIC8(CPUX86State *env, uint8_t v1, uint8_t v2,
^
/Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_emu.c:973:42:
error: too few arguments to function call,
      expected 4, have 2
        SET_FLAGS_OSZAPC_LOGIC16(env, res);
        ~~~~~~~~~~~~~~~~~~~~~~~~         ^
/Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_flags.h:75:1:
note: 'SET_FLAGS_OSZAPC_LOGIC16' declared here
void SET_FLAGS_OSZAPC_LOGIC16(CPUX86State *env, uint16_t v1, uint16_t v2,
^
/Users/brendan/Sandbox/qemu-bonzini/target/i386/hvf/x86_emu.c:982:42:
error: too few arguments to function call,
      expected 4, have 2
        SET_FLAGS_OSZAPC_LOGIC32(env, res);
        ~~~~~~~~~~~~~~~~~~~~~~~~         ^

Brendan.