[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/6] tcg: drop cpu->created check
From: |
Igor Mammedov |
Subject: |
[PATCH 6/6] tcg: drop cpu->created check |
Date: |
Wed, 29 Jan 2025 14:44:36 +0100 |
previous commits fixed 2 remaining cases where vcpu might
have had 'cpu->created == false' during 1st vcpu reset (at realize time)
that leads to call chain
tcg_cpu_reset_hold() => tlb_flush_by_mmuidx()
remove not need anymore check, with cpu->created always being true.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
accel/tcg/cputlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index db1713b3ca..f4f3965518 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -75,7 +75,7 @@
} while (0)
#define assert_cpu_is_self(cpu) \
- tcg_debug_assert(!(cpu)->created || qemu_cpu_is_self(cpu))
+ tcg_debug_assert(qemu_cpu_is_self(cpu))
/* run_on_cpu_data.target_ptr should always be big enough for a
* vaddr even on 32 bit builds
@@ -416,7 +416,7 @@ void tlb_flush_by_mmuidx(CPUState *cpu, uint16_t idxmap)
{
tlb_debug("mmu_idx: 0x%" PRIx16 "\n", idxmap);
- if (cpu->created && !qemu_cpu_is_self(cpu)) {
+ if (!qemu_cpu_is_self(cpu)) {
async_run_on_cpu(cpu, tlb_flush_by_mmuidx_async_work,
RUN_ON_CPU_HOST_INT(idxmap));
} else {
--
2.43.0
- [PATCH 0/6] tcg: fix qemu crash when add assert_cpu_is_self() is enabled and cleanups related to cpu->created check, Igor Mammedov, 2025/01/29
- [PATCH 2/6] loongarch: reset vcpu after it's created, Igor Mammedov, 2025/01/29
- [PATCH 1/6] bsd-user: drop not longer used target_reset_cpu(), Igor Mammedov, 2025/01/29
- [PATCH 3/6] m68k: reset vcpu after it's created, Igor Mammedov, 2025/01/29
- [PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self(), Igor Mammedov, 2025/01/29
- [PATCH 5/6] Revert "tcg/cputlb: remove other-cpu capability from TLB flushing", Igor Mammedov, 2025/01/29
- [PATCH 6/6] tcg: drop cpu->created check,
Igor Mammedov <=