[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self()
From: |
Igor Mammedov |
Subject: |
[PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self() |
Date: |
Wed, 29 Jan 2025 14:44:34 +0100 |
that will enable assert_cpu_is_self when QEMU is configured with
--enable-debug
without need for manual patching DEBUG_TLB_GATE define.
Need to manually path DEBUG_TLB_GATE define to enable assert,
let regression caused by [1] creep in unnoticed.
1) 30933c4fb4f3d ("tcg/cputlb: remove other-cpu capability from TLB flushing")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
---
accel/tcg/cputlb.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index b4ccf0cdcb..71207d6dbf 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -61,8 +61,8 @@
# define DEBUG_TLB_LOG_GATE 0
# endif
#else
-# define DEBUG_TLB_GATE 0
-# define DEBUG_TLB_LOG_GATE 0
+# define DEBUG_TLB_GATE 1
+# define DEBUG_TLB_LOG_GATE 1
#endif
#define tlb_debug(fmt, ...) do { \
@@ -74,11 +74,8 @@
} \
} while (0)
-#define assert_cpu_is_self(cpu) do { \
- if (DEBUG_TLB_GATE) { \
- g_assert(!(cpu)->created || qemu_cpu_is_self(cpu)); \
- } \
- } while (0)
+#define assert_cpu_is_self(cpu) \
+ tcg_debug_assert(!(cpu)->created || qemu_cpu_is_self(cpu))
/* run_on_cpu_data.target_ptr should always be big enough for a
* vaddr even on 32 bit builds
--
2.43.0
- [PATCH 0/6] tcg: fix qemu crash when add assert_cpu_is_self() is enabled and cleanups related to cpu->created check, Igor Mammedov, 2025/01/29
- [PATCH 2/6] loongarch: reset vcpu after it's created, Igor Mammedov, 2025/01/29
- [PATCH 1/6] bsd-user: drop not longer used target_reset_cpu(), Igor Mammedov, 2025/01/29
- [PATCH 3/6] m68k: reset vcpu after it's created, Igor Mammedov, 2025/01/29
- [PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self(),
Igor Mammedov <=
- [PATCH 5/6] Revert "tcg/cputlb: remove other-cpu capability from TLB flushing", Igor Mammedov, 2025/01/29
- [PATCH 6/6] tcg: drop cpu->created check, Igor Mammedov, 2025/01/29