qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/11] hw/sd: Remove unused legacy functions, stop killing ma


From: Richard Henderson
Subject: Re: [PATCH 10/11] hw/sd: Remove unused legacy functions, stop killing mammoths
Date: Tue, 28 Jan 2025 11:10:19 -0800
User-agent: Mozilla Thunderbird

On 1/28/25 02:45, Peter Maydell wrote:
The sdcard_legacy.h header defines function prototypes for the "legacy"
SD card API, which was used by non-qdevified SD controller models.
We've now converted the only remaining non-qdev SD controller, so
we can drop the legacy API.

Entirely unused functions:
   sd_init(), sd_set_cb(), sd_enable()

Functions which now become static inside sd.c (they are the
underlying implementations of methods on SDCardClass):
   sd_do_command(), sd_write_byte(), sd_read_byte()

Removal of sd_init() means that we can also remove the
me_no_qdev_me_kill_mammoth_with_rocks flag, the codepaths that were
only reachable when it was set, and the inserted_cb and readonly_cb
qemu_irq lines that went with that.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/hw/sd/sdcard_legacy.h | 50 -----------------------
  hw/sd/omap_mmc.c              |  2 +-
  hw/sd/sd.c                    | 77 ++++-------------------------------
  3 files changed, 9 insertions(+), 120 deletions(-)
  delete mode 100644 include/hw/sd/sdcard_legacy.h

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]