[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] tests/qtest/migration: add postcopy tests with multif
From: |
Prasad Pandit |
Subject: |
Re: [PATCH v4 4/4] tests/qtest/migration: add postcopy tests with multifd |
Date: |
Tue, 28 Jan 2025 22:15:41 +0530 |
On Tue, 28 Jan 2025 at 19:20, Fabiano Rosas <farosas@suse.de> wrote:
> You could include qapi-types-migration.h and use the actual enum, that
> avoids the burden of having to keep the tests in sync with the code.
>
> (I don't think keeping the caps in sync with the current-version tests
> would break the compat tests, but please consider that as well)
>
> And a generic helper that calls migrate_set_capability() for any
> capabilites set. That solves the capabilities issue for all tests. We
> can then move some default parameters setting into that function and
> that should already reduce the number of hooks needed.
* Okay, will check.
> You can include it in this series or send a separate one, whatever is
> easier for you. But we need to base this one on top of it eventually, I
> would just send everything at once.
* Okay, will send it as part of this series then.
Thank you.
---
- Prasad