[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] tests/qtest/migration: add postcopy tests with multif
From: |
Prasad Pandit |
Subject: |
Re: [PATCH v4 4/4] tests/qtest/migration: add postcopy tests with multifd |
Date: |
Tue, 28 Jan 2025 16:47:02 +0530 |
On Tue, 28 Jan 2025 at 11:00, Prasad Pandit <ppandit@redhat.com> wrote:
> > for (int i = 0; i < MIGRATION_CAPABILITY__MAX; i++) {
> > if (args->caps[i]) {
> > migrate_set_capability(from,
> > MigrationCapability_str(args->caps[i]), true);
> > migrate_set_capability(to,
> > MigrationCapability_str(args->caps[i]), true);
> > }
> > }
> >
> > We could also set the number of channels as a default value. The tests
> > could overwrite it from the hook if needed.
>
> * Yes, this seems like a better option, I'll give it a try.
Please see ->
https://notebin.de/?317b9fc90a9a910d#dGKqq4r5pyMYU5SXYLFhd8wrzKRCxCcokTkTRBCUK7w
@Fabiano: does this look okay? If it is, I'll further remove
corresponding boolean fields from MigrateCommon struct etc.
Thank you.
---
- Prasad