Re: [PATCH v1 1/2] virtio-mem-pci: Allow setting nvectors, so we can use MSI-X

[David Hildenbrand]

On 27.01.25 16:28, Thomas Huth wrote:
> On 27/01/2025 15.28, David Hildenbrand wrote:
> > Let's do it similar as virtio-balloon-pci. With this change, we can
> > use virtio-mem-pci on s390x, although plugging will still fail until
> > properly wired up in the machine.
> >
> > Signed-off-by: David Hildenbrand <david@redhat.com>
> > ---
> >    hw/core/machine.c          |  3 +++
> >    hw/virtio/virtio-mem-pci.c | 12 ++++++++++++
> >    2 files changed, 15 insertions(+)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 8f396ef803..5e1d9e12ef 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -41,6 +41,9 @@ GlobalProperty hw_compat_9_2[] = {
> >        { "virtio-balloon-pci", "vectors", "0" },
> >        { "virtio-balloon-pci-transitional", "vectors", "0" },
> >        { "virtio-balloon-pci-non-transitional", "vectors", "0" },
> > +    { "virtio-mem-pci", "vectors", "0" },
> > +    { "virtio-mem-pci-transitional", "vectors", "0" },
> > +    { "virtio-mem-pci-non-transitional", "vectors", "0" },
>
>    Hi!
>
> Do we need the entries fo the -transitional and -non-transitional devices?
> Since virtio-mem is rather new, I would expect that those should not exist
> here? E.g. virtio-balloon-pci.c has:
>
>       .transitional_name     = "virtio-balloon-pci-transitional",
>       .non_transitional_name = "virtio-balloon-pci-non-transitional",
>
> but there are no such entries in virtio-mem-pci.c ... ?

Oh, very good point. Yes, I think we can just drop this legacy stuff.

Thanks!

--
Cheers,

David / dhildenb