Re: [PATCH v1 2/2] s390x/s390-virtio-ccw: Support plugging PCI-based virtio memory devices

[David Hildenbrand]

> >   
> > @@ -589,10 +593,12 @@ static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,
> >   {
> >       if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> >           error_setg(errp, "CPU hot unplug not supported on this machine");
> > -        return;
>
> This looks suspicious. Do we really want to continue executing the rest
> of the function in this case (though there's nothing to execute
> currently)?

These functions are usually a big switch-case statement, so the "return" 
is actually superfluous.

Note that this is already what we do with TYPE_CPU in 
s390_machine_device_plug().

Thanks!


--
Cheers,

David / dhildenb