qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 74/76] target/i386: Use correct type for get_float_exception_


From: Richard Henderson
Subject: Re: [PATCH 74/76] target/i386: Use correct type for get_float_exception_flags() values
Date: Sun, 26 Jan 2025 05:30:55 -0800
User-agent: Mozilla Thunderbird

On 1/24/25 08:28, Peter Maydell wrote:
The softfloat get_float_exception_flags() function returns 'int', but
in various places in target/i386 we incorrectly store the returned
value into a uint8_t.  This currently has no ill effects because i386
doesn't care about any of the float_flag enum values above 0x40.
However, we want to start using float_flag_input_denormal_used, which
is 0x4000.

Switch to using 'int' so that we can handle all the possible valid
float_flag_* values. This includes changing the return type of
save_exception_flags() and the argument to merge_exception_flags().

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  target/i386/ops_sse.h        | 16 +++----
  target/i386/tcg/fpu_helper.c | 82 ++++++++++++++++++------------------
  2 files changed, 49 insertions(+), 49 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]