qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/85] target/sparc: Move FBPfcc and FBfcc to decodetree


From: Richard Henderson
Subject: Re: [PATCH 09/85] target/sparc: Move FBPfcc and FBfcc to decodetree
Date: Sun, 26 Jan 2025 04:25:23 -0800
User-agent: Mozilla Thunderbird

On 1/26/25 01:38, Artyom Tarasenko wrote:
Hi Richard,

On Fri, Oct 13, 2023 at 11:29 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/sparc/insns.decode |   4 ++
  target/sparc/translate.c  | 105 +++++++++++++++-----------------------
  2 files changed, 46 insertions(+), 63 deletions(-)

diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode
index 838f4cdb1d..9ab3f2eb82 100644
--- a/target/sparc/insns.decode
+++ b/target/sparc/insns.decode
@@ -6,8 +6,12 @@
  &bcc    i a cond cc
  BPcc    00 a:1 cond:4   001 cc:1 0 - i:s19                 &bcc
  Bicc    00 a:1 cond:4   010          i:s22                 &bcc cc=0
+FBPfcc  00 a:1 cond:4   101 cc:2   - i:s19                 &bcc
+FBfcc   00 a:1 cond:4   110          i:s22                 &bcc cc=0

  %d16    20:s2 0:14
  BPr     00 a:1 0 cond:3 011 ..     - rs1:5 ..............  i=%d16

+NCP     00 -   ----     111 ----------------------         # CBcc
Do we have a convention, when do we use "-" and when "."?
Dots are decoded by something (@format, %field, etc).
Dashes are completely ignored.
See "fixedbit_elt" in docs/devel/decodetree.rst.

I plan to add a few instructions which do something with special
registers on OpenSparc, but would be nop in QEMU. Shall I use dots? Or
rather dashes?
That depends on what it is.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]