Re: [PATCH 09/85] target/sparc: Move FBPfcc and FBfcc to decodetree

[Artyom Tarasenko]

Hi Richard,

On Fri, Oct 13, 2023 at 11:29 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/sparc/insns.decode |   4 ++
>  target/sparc/translate.c  | 105 +++++++++++++++-----------------------
>  2 files changed, 46 insertions(+), 63 deletions(-)
>
> diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode
> index 838f4cdb1d..9ab3f2eb82 100644
> --- a/target/sparc/insns.decode
> +++ b/target/sparc/insns.decode
> @@ -6,8 +6,12 @@
>  &bcc    i a cond cc
>  BPcc    00 a:1 cond:4   001 cc:1 0 - i:s19                 &bcc
>  Bicc    00 a:1 cond:4   010          i:s22                 &bcc cc=0
> +FBPfcc  00 a:1 cond:4   101 cc:2   - i:s19                 &bcc
> +FBfcc   00 a:1 cond:4   110          i:s22                 &bcc cc=0
>
>  %d16    20:s2 0:14
>  BPr     00 a:1 0 cond:3 011 ..     - rs1:5 ..............  i=%d16
>
> +NCP     00 -   ----     111 ----------------------         # CBcc

Do we have a convention, when do we use "-" and when "."?
I plan to add a few instructions which do something with special
registers on OpenSparc, but would be nop in QEMU. Shall I use dots? Or
rather dashes?

Regards,
Artyom