[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] rust: pl011: remove duplicate definitions
From: |
Zhao Liu |
Subject: |
Re: [PATCH 08/10] rust: pl011: remove duplicate definitions |
Date: |
Thu, 23 Jan 2025 14:12:00 +0800 |
On Fri, Jan 17, 2025 at 10:26:55AM +0100, Paolo Bonzini wrote:
> Date: Fri, 17 Jan 2025 10:26:55 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 08/10] rust: pl011: remove duplicate definitions
> X-Mailer: git-send-email 2.47.1
>
> Unify the "Interrupt" enum and the "INT_*" constants with a struct
> that contains the bits. The "int_level" and "int_enabled" fields
> could use a crate such as "bitflags".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/char/pl011/src/device.rs | 36 ++++++++++++-------------
> rust/hw/char/pl011/src/lib.rs | 46 +++++++++++---------------------
> 2 files changed, 33 insertions(+), 49 deletions(-)
>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
- [PATCH 06/10] rust: pl011: extract PL011Registers, (continued)
- [PATCH 06/10] rust: pl011: extract PL011Registers, Paolo Bonzini, 2025/01/17
- [PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops, Paolo Bonzini, 2025/01/17
- [PATCH 07/10] rust: pl011: wrap registers with BqlRefCell, Paolo Bonzini, 2025/01/17
- [PATCH 10/10] rust: qdev: make reset take a shared reference, Paolo Bonzini, 2025/01/17
- [PATCH 08/10] rust: pl011: remove duplicate definitions, Paolo Bonzini, 2025/01/17
- Re: [PATCH 08/10] rust: pl011: remove duplicate definitions,
Zhao Liu <=
- [PATCH 09/10] rust: pl011: pull device-specific code out of MemoryRegionOps callbacks, Paolo Bonzini, 2025/01/17