Re: [PATCH 7/9] test/functional: Update the Aspeed aarch64 test

[Cédric Le Goater]

On 1/22/25 08:28, Jamin Lin wrote:
> Hi Cedric,
>
> > From: Cédric Le Goater <clg@redhat.com>
> > Sent: Wednesday, January 22, 2025 3:09 PM
> > To: qemu-arm@nongnu.org; qemu-devel@nongnu.org
> > Cc: Joel Stanley <joel@jms.id.au>; Andrew Jeffery
> > <andrew@codeconstruct.com.au>; Troy Lee <troy_lee@aspeedtech.com>;
> > Jamin Lin <jamin_lin@aspeedtech.com>; Steven Lee
> > <steven_lee@aspeedtech.com>; Cédric Le Goater <clg@redhat.com>
> > Subject: [PATCH 7/9] test/functional: Update the Aspeed aarch64 test
> >
> > Bumped SDK version to v09.03. v09.04 is available but not yet supported in
> > QEMU.
> >
> > Signed-off-by: Cédric Le Goater <clg@redhat.com>
> > ---
> >   tests/functional/test_aarch64_aspeed.py | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tests/functional/test_aarch64_aspeed.py
> > b/tests/functional/test_aarch64_aspeed.py
> > index 141d86385936..6a9ae2a34956 100755
> > --- a/tests/functional/test_aarch64_aspeed.py
> > +++ b/tests/functional/test_aarch64_aspeed.py
> > @@ -27,14 +27,14 @@ def do_test_aarch64_aspeed_sdk_start(self, image):
> >           wait_for_console_pattern(self, '## Loading kernel from FIT Image')
> >           wait_for_console_pattern(self, 'Starting kernel ...')
> >
> > -    ASSET_SDK_V902_AST2700 = Asset(
> > -
> > 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.02/ast
> > 2700-default-obmc.tar.gz',
> > -
> > 'ac969c2602f4e6bdb69562ff466b89ae3fe1d86e1f6797bb7969d787f82116a7')
> > +    ASSET_SDK_V903_AST2700 = Asset(
> > +
> > 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.03/ast
> > 2700-default-obmc.tar.gz',
> > +
> > +
> > '91225f50d255e2905ba8d8e0c80b71b9d157c3609770c7a740cd786370d85a77'
> > )
> >
> >       def test_aarch64_ast2700_evb_sdk_v09_02(self):
> Do we need to change v09_03?

Indeed ! Will fix.

> Others looks good to me.
>
> Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>

Thanks,

C.