Re: [PATCH V7 24/24] migration: cpr-transfer documentation

[Fabiano Rosas]

Steven Sistare <steven.sistare@oracle.com> writes:

> On 1/17/2025 2:06 PM, Fabiano Rosas wrote:
>>   Steven Sistare <steven.sistare@oracle.com> writes:
>> 
>>> On 1/17/2025 10:29 AM, Fabiano Rosas wrote:
>>>> Steven Sistare <steven.sistare@oracle.com> writes:
>>>>
>>>>> On 1/17/2025 9:42 AM, Fabiano Rosas wrote:
>>>>>> Steve Sistare <steven.sistare@oracle.com> writes:
> [...]
>>>
>>> Thank-you for the simple example.  I reproduced the failure.
>>> To fix, add "-machine aux-ram-share=on -machine memory-backend=ram0"
>>> (The previous longer example had the former but lacked the latter).
>>> Without that, the volatile pc.ram region is still in the mix.
>> 
>> There you go, that kvm-tpr-opt message is almost always indicative of
>> user error. I think because it's the first vmstate to be loaded.
>> 
>> Nonetheless, we better update the documentation to:
>> 
>> -object memory-backend-file,id=ram0,size=4G,mem-path=/dev/shm/ram0,share=on 
>> -m -4G \
>> -machine memory-backend=ram0 \
>> -machine aux-ram-share=on
>
> Agreed.  Will you squash it in to both examples?

Yep, no worries.

>
> - Steve