[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier
From: |
Andrew Cooper |
Subject: |
Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier |
Date: |
Wed, 15 Jan 2025 16:46:19 +0000 |
User-agent: |
Mozilla Thunderbird |
On 15/01/2025 4:27 pm, David Woodhouse wrote:
> diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> index adfc4efad0..85b92cded4 100644
> --- a/hw/xen/xen-bus.c
> +++ b/hw/xen/xen-bus.c
> @@ -650,6 +650,16 @@ int xen_device_frontend_scanf(XenDevice *xendev, const
> char *key,
> return rc;
> }
>
> +char *xen_device_frontend_read(XenDevice *xendev, const char *key)
> +{
> + XenBus *xenbus = XEN_BUS(qdev_get_parent_bus(DEVICE(xendev)));
> +
> + g_assert(xenbus->xsh);
> +
> + return xs_node_read(xenbus->xsh, XBT_NULL, NULL, NULL, "%s/%s",
> + xendev->frontend_path, key);;
Double ;;
~Andrew
- [PATCH v3 1/7] xen: error handling and FreeBSD compatibility fixes, David Woodhouse, 2025/01/15
- [PATCH v3 5/7] hw/xen: Use xs_node_read() from xen_netdev_get_name(), David Woodhouse, 2025/01/15
- [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function, David Woodhouse, 2025/01/15
- [PATCH v3 2/7] xen: do not use '%ms' scanf specifier, David Woodhouse, 2025/01/15
- [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console, David Woodhouse, 2025/01/15
- [PATCH v3 3/7] hw/xen: Use xs_node_read() from xs_node_vscanf(), David Woodhouse, 2025/01/15
- [PATCH v3 4/7] hw/xen: Use xs_node_read() from xen_console_get_name(), David Woodhouse, 2025/01/15
- [PATCH v3 6/7] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it, David Woodhouse, 2025/01/15