[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier
|
From: |
Anthony PERARD |
|
Subject: |
Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier |
|
Date: |
Wed, 15 Jan 2025 17:45:03 +0100 |
On Wed, Jan 15, 2025 at 04:27:20PM +0000, David Woodhouse wrote:
> From: Roger Pau Monne <roger.pau@citrix.com>
>
> The 'm' parameter used to request auto-allocation of the destination variable
> is not supported on FreeBSD, and as such leads to failures to parse.
>
> What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
> it just leads to a double allocation of the same string. Instead use
> xs_node_read() to read the whole xenstore node.
>
> Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create
> XenDevice-s...')
> Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony PERARD
- [PATCH v3 1/7] xen: error handling and FreeBSD compatibility fixes, David Woodhouse, 2025/01/15
- [PATCH v3 5/7] hw/xen: Use xs_node_read() from xen_netdev_get_name(), David Woodhouse, 2025/01/15
- [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function, David Woodhouse, 2025/01/15
- [PATCH v3 2/7] xen: do not use '%ms' scanf specifier, David Woodhouse, 2025/01/15
- [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console, David Woodhouse, 2025/01/15
- [PATCH v3 3/7] hw/xen: Use xs_node_read() from xs_node_vscanf(), David Woodhouse, 2025/01/15
- [PATCH v3 4/7] hw/xen: Use xs_node_read() from xen_console_get_name(), David Woodhouse, 2025/01/15
- [PATCH v3 6/7] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it, David Woodhouse, 2025/01/15