Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

[Michael Tokarev]

13.01.2025 09:39, Thomas Huth wrote:
> On 12/01/2025 15.29, Michael Tokarev wrote:

> > # starting QEMU: exec ./qemu-system-s390x -qtest unix:/tmp/ qtest-1137270.sock -qtest-log /dev/null -chardev socket,path=/tmp/ 
> > qtest-1137270.qmp,id=char0 -mon chardev=char0,mode=control -display none - audio none -accel kvm -accel tcg -machine s390-ccw-virtio-9.2, -name 
> > target,debug-threads=on -m 128M -serial file:/tmp/migration-test-T987Z2/ dest_serial -incoming tcp:127.0.0.1:0 -bios /tmp/migration-test-T987Z2/ 
> > bootsect     -accel qtest
> > Traceback (most recent call last):
> >    File "/tmp/q/scripts/analyze-migration.py", line 704, in <module>
> >      dump.read(dump_memory = args.memory)
> >    File "/tmp/q/scripts/analyze-migration.py", line 641, in read
> >      section.read()
> >    File "/tmp/q/scripts/analyze-migration.py", line 477, in read
> >      field['data'] = reader(field, self.file)
> >                      ^^^^^^^^^^^^^^^^^^^^^^^^
> >    File "/tmp/q/scripts/analyze-migration.py", line 450, in __init__
> >      for field in self.desc['struct']['fields']:
> >                   ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
> > KeyError: 'fields'
> > # Failed to analyze the migration stream
>
> I think you need to backport patch 1/7, too?

Picked up:

 1/7 migration: Add more error handling to analyze-migration.py
 3/7 migration: Fix parsing of s390 stream
 7/7 s390x: Fix CSS migration

but still getting the same error:

 https://gitlab.com/mjt0k/qemu/-/jobs/8832218999 (9.2 branch)
 https://gitlab.com/mjt0k/qemu/-/jobs/8832224338 (9.1 branch)

Thanks,

/mjt